Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32837 )
Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32837/4/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32837/4/src/arch/x86/smbios.c@143
PS4, Line 143: 0x9b05
isn't 0x9b85 ?
Yes, odd parity shall be 0x9b85
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32837
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10a268a7f3bde405b95bd3a16d5d121be623c7ed
Gerrit-Change-Number: 32837
Gerrit-PatchSet: 4
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 May 2019 16:41:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment