Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45376 )
Change subject: soc/intel/xeon_sp/cpx: search IIO_UDS HOB once when creating DMAR table
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45376/2/src/soc/intel/xeon_sp/cpx/a...
File src/soc/intel/xeon_sp/cpx/acpi.c:
https://review.coreboot.org/c/coreboot/+/45376/2/src/soc/intel/xeon_sp/cpx/a...
PS2, Line 620: true
This derefrences a nullptr. You need to check it for NULL. […]
If is_atsr is true, then first is not NULL. Otherwise first can be NULL since && operator guarantees the second test is not executed.
That being said, I added check for NULL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45376
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I469cd8473c50e105daeda6c5607592ae7cef6032
Gerrit-Change-Number: 45376
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Sep 2020 23:39:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Gerrit-MessageType: comment