Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31621 )
Change subject: soc/intel/cannonlake: Move common definitions to a header file
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31621/1/src/soc/intel/cannonlake/include/soc...
File src/soc/intel/cannonlake/include/soc/gpio_common.h:
https://review.coreboot.org/#/c/31621/1/src/soc/intel/cannonlake/include/soc...
PS1, Line 15: #ifndef _SOC_CANNONLAKE_GPIO_COMMON_H_
: #define _SOC_CANNONLAKE_GPIO_COMMON_H_
please add empty lines around these
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31621
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If47692ecb05134db1ee6c0fb10125d6a1b67f127
Gerrit-Change-Number: 31621
Gerrit-PatchSet: 2
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 Feb 2019 19:01:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment