John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41042 )
Change subject: device: Add a disabling PCIe device bus master function
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41042/2/src/device/pci_device.c
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/41042/2/src/device/pci_device.c@157...
PS2, Line 1572: /**
: * Disable device bus master.
: *
: * This function is to disable device bus master.
: *
: * @param dev Pointer to the device.
: */
Please don't write boiler-plate comments. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41042
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie92a15bf2c66fdc311098acb81019d4fb7f68313
Gerrit-Change-Number: 41042
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 May 2020 20:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment