Patrik Tesarik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38225 )
Change subject: doc/tutorial/part1.md: Add commands for yum- & pacman-based distro ......................................................................
Patch Set 10:
(10 comments)
Thanks for your constructive feedback, Angel!
https://review.coreboot.org/c/coreboot/+/38225/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38225/7//COMMIT_MSG@7 PS7, Line 7: Add information for yum- & pacman-based distro
Add commands for more distros
Ack
https://review.coreboot.org/c/coreboot/+/38225/7//COMMIT_MSG@9 PS7, Line 9: Additional
Missing a verb: […]
Ack
https://review.coreboot.org/c/coreboot/+/38225/7//COMMIT_MSG@10 PS7, Line 10: S
lowercase
Ack
https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/part... File Documentation/tutorial/part1.md:
https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/part... PS7, Line 4: From a fresh Ubuntu 16.04 or 18.04 install, here are all the steps required for
This might need an update. […]
Ack
https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/part... PS7, Line 11: $ sudo apt-get install -y bison build-essential curl flex git gnat libncurses5-dev m4 zlib1g-dev
Maybe indicate that these commands are for different distros? […]
I introduced the package management specific instructions in the preambel. It should be clear which command to use in the following tutorial/
https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/part... PS7, Line 82: $ sudo apt-get install -y qemu
same here, these commands are for different distros
Ack
https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/part... PS7, Line 98: for Debian, CentOS or : Arch based
If commands for another package manager are added, this would need to be changed. […]
Ack
https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/part... PS7, Line 103: t : comes pre-installed on some Ubuntu flavors and maybe not on others.
I don't think this sentence is of much value, given the paragraph right before it
Ack
https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/part... PS7, Line 111: that does not use apt, yum or : pacman as its package manager
Same as before. I would omit it, as it's easily inferred.
Ack
https://review.coreboot.org/c/coreboot/+/38225/7/Documentation/tutorial/part... PS7, Line 137: coreboot's : file system
nit: as CBFS is 'CoreBoot File System' (capitals only used for emphasis), I would change this part a […]
Ack