Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36645 )
Change subject: soc/intel/{apl,dnv,quark}: Use strip_quotes for FSP options
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/36645/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36645/1//COMMIT_MSG@9
PS1, Line 9: 1058dd84f06fa2fcbdd99eb99da07dccdf5b9722
Do you mean 8fc523e3137cfdde970a3c87e22b8bbc586a3f7e?
Also, if you remove the parentheses, "commit 12345" will link to the commit in the Gerrit UI.
https://review.coreboot.org/c/coreboot/+/36645/1//COMMIT_MSG@11
PS1, Line 11: incomplete
The assumption that FSP_M_CBFS, set from src/drivers/intel/fsp2_0/Makefile.inc is available in the SoCs seemed to be deliberate, but it's wrong.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36645
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48e5fa36e1ad799d09714f53a3041f73b8ec3550
Gerrit-Change-Number: 36645
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Nov 2019 10:38:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment