HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44699 )
Change subject: soc/mediatek/mt8192: Add dram control register define and bits define ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44699/1/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/dramc_pi_api.h:
https://review.coreboot.org/c/coreboot/+/44699/1/src/soc/mediatek/mt8192/inc... PS1, Line 17: #define dramc_err(_x_...) printk(BIOS_ERR, _x_) : #define dramc_info(_x_...) printk(BIOS_INFO, _x_) : #if CONFIG(DEBUG_DRAM) : #define dramc_dbg(_x_...) printk(BIOS_INFO, _x_) : #else : #define dramc_dbg(_x_...) : #endif should we use this for coreboot tree ?
https://review.coreboot.org/c/coreboot/+/44699/1/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/dramc_register.h:
https://review.coreboot.org/c/coreboot/+/44699/1/src/soc/mediatek/mt8192/inc... PS1, Line 6: types.h <types.h> is ok, but you used only <stdint.h>