Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 44:
(3 comments)
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 171: if (CONFIG(BOARD_ASUS_A88XM_E))
Is this ever false?
Removed this and another similar worthless "if" at BiosCallOuts.c (guess they helped an easier comparison of F2A85-M vs A88XM-E sources).
https://review.coreboot.org/c/coreboot/+/30987/42/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/30987/42/src/mainboard/asus/a88xm-e... PS42, Line 163: /* TODO: is this OK for DDR3 socket FM2? */ : /* : MEMCLK_DIS_MAP(ANY_SOCKET, ANY_CHANNEL, 0x01, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00), : CKE_TRI_MAP(ANY_SOCKET, ANY_CHANNEL, 0x05, 0x0A), : ODT_TRI_MAP(ANY_SOCKET, ANY_CHANNEL, 0x01, 0x02, 0x00, 0x00), : CS_TRI_MAP(ANY_SOCKET, ANY_CHANNEL, 0x01, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00), : */ Do you think this MEMCLK_DIS_MAP gem (taken from F2A85-M sources) might be a key for a Turtle RAM issue? https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/MHAXQ...
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/mptable.c:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 38: };
Will do as soon as possible, also will revert the move of some romstage.c code to bootblock. […]
Done, although not boot tested yet.