Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37306 )
Change subject: trogdor: mainboard reference all QUPv3 FW drivers ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37306/12/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37306/12/src/mainboard/google/trogd... PS12, Line 43: qup_spi_init(QUPV3_1_SE0, 1010 * KHz); /* H1 SPI */ These are incorrect, each bus should only be initialized once (and these are already in the bootblock).
https://review.coreboot.org/c/coreboot/+/37306/12/src/mainboard/google/trogd... PS12, Line 50: uart_init(QUPV3_0_SE3); /* BT UART */ For those which we're not going to use in firmware, we don't have to do the whole controller init. Just do a qup_load_se_firmware() directly. (Also, factor all these out into a separate function for readability, e.g. load_qup_firmwares() or something.)