Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45588 )
Change subject: spd: move weak mainboard_get_dram_part_num implementation to lib/spd_bin.c
......................................................................
Patch Set 24:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45588/18/src/include/memory_info.h
File src/include/memory_info.h:
https://review.coreboot.org/c/coreboot/+/45588/18/src/include/memory_info.h@...
PS18, Line 116: ength of string not including the null terminator
re: "Looking at the implementation, len seems to return the length of string including '\0' terminat […]
Since this CL is the one providing the notion of a common mainboard_get_dram_part_num(), why not start with the correct function prototype in this CL itself? This will avoid the change in CB:45636 to again update the prototype and touch the common code in memory_info.h and spd_bin.c.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45588
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie173b81b9c9a98f3744cc9da4b034d2251f5589b
Gerrit-Change-Number: 45588
Gerrit-PatchSet: 24
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 30 Sep 2020 15:52:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment