9 Jan
2020
9 Jan
'20
6:42 p.m.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support ......................................................................
Patch Set 44: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/33234/44/src/security/intel/stm/Stm... File src/security/intel/stm/StmPlatformResource.c:
https://review.coreboot.org/c/coreboot/+/33234/44/src/security/intel/stm/Stm... PS44, Line 113: #ifndef ACPI_BASE_ADDRESS
please remove
Eugene in case there is confusion, please remove the whole commented out block.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33234
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4adcd92c341162630ce1ec357ffcf8a135785ec
Gerrit-Change-Number: 33234
Gerrit-PatchSet: 44
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Jonathan Zhang jonzhang@fb.com
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Thu, 09 Jan 2020 17:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment