build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26603 )
Change subject: src/northbridge: Get rid of whitespace before tab ......................................................................
Patch Set 7:
(14 comments)
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/agesa/family14/c... File src/northbridge/amd/agesa/family14/chip.h:
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/agesa/family14/c... PS7, Line 30: * { {0x00, 0x00}, {0x00, 0x00}, }, // socket 1 - Channel 0 & 1 (Unused) line over 80 characters
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdht/h3gtopo.h File src/northbridge/amd/amdht/h3gtopo.h:
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdht/h3gtopo.h@... PS7, Line 259: 0x00, 0x44, 0x00, 0x44, 0x00, 0x44, 0x00, 0x44, 0x00, 0x44, 0x00, 0x44, 0x10, 0xFF // Node6 line over 80 characters
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdk8/northbridg... File src/northbridge/amd/amdk8/northbridge.c:
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdk8/northbridg... PS7, Line 993: if (!is_cpu_pre_e0()) suspect code indent for conditional statements (40, 49)
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdk8/northbridg... PS7, Line 995: sizek += hoist_memory(mmio_basek, i); line over 80 characters
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdk8/northbridg... PS7, Line 1220: e0_later_single_core = is_e0_later_in_bsp(i); // single core line over 80 characters
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdk8/northbridg... PS7, Line 1222: e0_later_single_core = is_cpu_f0_in_bsp(i); // We can read cpuid(1) from Func3 line over 80 characters
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdk8/raminit.c File src/northbridge/amd/amdk8/raminit.c:
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdk8/raminit.c@... PS7, Line 1310: uint8_t rdpreamble[4]; /* 0 is for registered, 1 for 1-2 DIMMS, 2 and 3 for 3 or 4 unreg dimm slots */ line over 80 characters
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdmct/mct/mct_d... File src/northbridge/amd/amdmct/mct/mct_d.c:
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdmct/mct/mct_d... PS7, Line 3756: * b) Reset the Begin Compensation bit (D3CMP->COMP_CONFIG[0]) in all the compensation engines line over 80 characters
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdmct/mct/mctdq... File src/northbridge/amd/amdmct/mct/mctdqs_d.c:
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdmct/mct/mctdq... PS7, Line 464: BanksPresent = 1; /* flag for at least one bank is present */ line over 80 characters
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mct_d.c:
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdmct/mct_ddr3/... PS7, Line 7912: * b) Reset the Begin Compensation bit (D3CMP->COMP_CONFIG[0]) in all the compensation engines line over 80 characters
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mctecc_d.c:
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdmct/mct_ddr3/... PS7, Line 118: OB_ChipKill = mctGet_NVbits(NV_ChipKill); /* ECC Chip-kill mode */ line over 80 characters
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdmct/mct_ddr3/... PS7, Line 123: /* mct_AdjustScrub_D(pDCTstatA, &nvbits); */ /* Need not adjust */ line over 80 characters
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/s3utils.c:
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/amdmct/mct_ddr3/... PS7, Line 699: // wrmsr_uint64_t(0x00000260 | (i + 8), data->msr0000026[i]); line over 80 characters
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/lx/northbridgein... File src/northbridge/amd/lx/northbridgeinit.c:
https://review.coreboot.org/#/c/26603/7/src/northbridge/amd/lx/northbridgein... PS7, Line 597: * SYSRC(7:0) = 00h ; writeback, can set to 08h to make writethrough line over 80 characters