Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30360 )
Change subject: mb/libretrend/lt1000: Add Libretrend LT1000 mainboard ......................................................................
Patch Set 15:
(7 comments)
https://review.coreboot.org/c/coreboot/+/30360/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/30360/15//COMMIT_MSG@7 PS15, Line 7: board support
I would just say `mainboard`
Done
https://review.coreboot.org/c/coreboot/+/30360/15/Documentation/mainboard/li... File Documentation/mainboard/libretrend/lt1000.md:
https://review.coreboot.org/c/coreboot/+/30360/15/Documentation/mainboard/li... PS15, Line 34: Strongly advised to
*It is* strongly advised to ...
Done
https://review.coreboot.org/c/coreboot/+/30360/15/Documentation/mainboard/li... PS15, Line 35: possessing the
having an
Done
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/acpi/mainboard.asl:
PS15:
I don't think we need this file
Done
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... PS15, Line 241: "THERMAL_MODE_DISABLED"
Should fit on the previous line
Done
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... PS15, Line 254: LVDS
backlight control?
Done
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/30360/15/src/mainboard/libretrend/l... PS15, Line 31: #include "acpi/mainboard.asl"
We don't need this
Done