mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31225 )
Change subject: src/mainboard/lenovo/g505s/Kconfig: disable DRIVERS_INTEL_WIFI by default
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
I think that until we find at least one G505S user who needs Intel WiFi we could safely default it to "n". Why default this to "y" if we don't know anyone who needs it?
My g505s now has Intel WiFi. Previously it had none.
Thank you very much for your feedback; although I couldn't understand your choice of Intel over ath9k, I see it as a good enough reason to abandon this change. Please also take a look at CB:31308 (disable for the emulation boards)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31225
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73c3c2587690dca653dd1b2a8d6ee9ff8b769ad4
Gerrit-Change-Number: 31225
Gerrit-PatchSet: 2
Gerrit-Owner: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: awokd@danwin1210.me
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb
mikebdp2@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 10 Feb 2019 12:36:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment