chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44804 )
Change subject: mb/google/vilboz: update telemetry settings ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44804/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44804/2/src/mainboard/google/zork/v... PS2, Line 24: telemetry_vddcr_soc_offset
This seems to be a uint32_t field(https://review.coreboot.org/cgit/coreboot. […]
In original Agesa,it will apply a UINT32 value for PCD,so it will convert the type as below PcdSet32(PcdTelemetry_VddcrSocOffset, (UINT32) (0-83)); And the UPD will set to the PCD directly, and in the end this PCD will pass an int32 value to SMU.