Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47308 )
Change subject: mb/google/zork: Init fingerprint GPIOs for boot vs resume ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47308/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47308/4//COMMIT_MSG@10 PS4, Line 10: This allows initialization of the : fingerprint GPIOs which need to be handled differently between wake : from S3 and boot from S5.
Sure, I'll add it. […]
Done
https://review.coreboot.org/c/coreboot/+/47308/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47308/4/src/mainboard/google/zork/v... PS4, Line 317: slp_typ != ACPI_S0
If you poweroff and power back on within 10 seconds, I think it should be waking up from S5. […]
Good point. I didn't test that, but I updated the code to just match ACPI_S3.