Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45878 )
Change subject: tigerlake mainboards: switch to devtree aliases for PMC MUX connectors ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45878/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45878/3/src/mainboard/google/voltee... PS3, Line 20: variant_init
port1 is present on all variants, right? Are we relying on the fw_config_probe on all variants to fi […]
I think they all have a port 1, but as you said, fw_config will effectively filter out the devices that don't need the config change.
https://review.coreboot.org/c/coreboot/+/45878/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45878/2/src/mainboard/google/voltee... PS2, Line 245: conn1
Confirmed, it just picked the first one. […]
Ack