Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34348 )
Change subject: soc/intel/{cnl,icl}: Get list of PCI devices that needs IRQ programming
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34348/15/src/soc/intel/icelake/irq....
File src/soc/intel/icelake/irq.c:
https://review.coreboot.org/c/coreboot/+/34348/15/src/soc/intel/icelake/irq....
PS15, Line 20: static const pci_devfn_t irq_devices[] = {
are there any devices that are in this list but not in the (dynamic) devicetree or vice-versa?
Yes, Host bridge, integrated graphics, PMC, p2SB
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34348
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3482172f6cb549dece23e2b8b09b8b79578b83b7
Gerrit-Change-Number: 34348
Gerrit-PatchSet: 15
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 22 Oct 2019 13:50:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment