[coreboot-gerrit] Change in coreboot[master]: src/device/oprom src/lib: Remove broken bootsplash display code

[Mimoja (Code Review)]

Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34518 )

Change subject: src/device/oprom src/lib: Remove broken bootsplash display code
......................................................................

Patch Set 6:

@Ron, @Stefan
Please allow me to disagree

While int jpeg_check_size(unsigned char *buf, int width, int height) exists, it is not used anywhere in the code. (Same as with jpeg_fetch_size)

If the FB is smaller then 1024*768*2 Bytes this code will overflow, given an appropriate jpeg image. For smaller FBs, for bigger bit-depth it will not display the result correctly.

If the image does not match 1024*768@16 it will not work (jpeg.c:300), limiting it to only this one resolution

Therefore i think this code was never able to work in its current state, something I would label "broken".