[coreboot-gerrit] Change in coreboot[master]: drivers/smmstore: Implement SMMSTORE version 2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40520 )

Change subject: drivers/smmstore: Implement SMMSTORE version 2
......................................................................

Patch Set 22:
> Patch Set 22:
> > Patch Set 22:
> > > Patch Set 22:
> > > > Patch Set 22: Code-Review+1
> > > >
> > > > (1 comment)
> > > >
> > > > Very cool stuff. Works out-of-the-box with patched TianoCore.
> > >
> > > can you provide a branch/commit and platform on which you're able to verify this with this current patchset?
> >
> > Recently I have used this commit:
> >
> > https://github.com/9elements/edk2-1/commit/59b3af6d0340ed01471018d68c693cd1d...
> >
> > and built coreboot with UEFI payload and this patch. Worked perfectly on Dell OptiPlex 9010 SFF (although you cannot use TianoCore debug build, because it will cause some timing issues with SMMSTORE related SMIs - some FVB write/read protocol calls gave success, some were aborted).
>
> I've tried this on the Asrock B85M Pro4, and something is definitely being saved: the language setting. I think it's the simplest thing one can use to verify persistence. I've also been able to add a new boot entry and it will be saved.
>
> Other settings such as changing the console output mode do not seem to persist across reboots, but I've no idea if they're supposed to work in the first place.

Forgot to mention: I've used the same TianoCore commit as Michał.