Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37324 )
Change subject: soc/amd/common: Access ACPIMMIO via proper symbols ......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37324/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37324/1//COMMIT_MSG@10 PS1, Line 10: addesses
addresses
Done
https://review.coreboot.org/c/coreboot/+/37324/13/src/soc/amd/common/block/a... File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/37324/13/src/soc/amd/common/block/a... PS13, Line 9:
An already-approved followup CB:42073 fixes this.
Done
https://review.coreboot.org/c/coreboot/+/37324/5/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/gpio_banks.h:
https://review.coreboot.org/c/coreboot/+/37324/5/src/soc/amd/common/block/in... PS5, Line 22: #define GPIO_BANK0_CONTROL(gpio) ((uintptr_t)acpimmio_gpio0 + ((gpio) * 4))
also maybe align the numerical constants to the right: […]
Removed with followup.