Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45682 )
Change subject: mb/google/zork/vilboz: Add new memory part H5ANAG6NDMR-XNC
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45682/2/src/mainboard/google/zork/v...
PS2, Line 15: H5ANAG6NDMR-XNC, 7
If the ID hasn't been used on any build, we should drop the 7 and let the tool assign it. […]
Due to HW have planned to use the RAM ID table from https://partnerissuetracker.corp.google.com/issues/165611994#comment5 for EVT schematic gerber out. If we dropped the 7 and let the tool assign it, 0 will be assigned and this will not meet the RAM ID table in EVT schematic. In the future we will use the tool to assign an ID before putting the ID in the schematic. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf613d54bf23b637e38917937ce3e78702b26a28
Gerrit-Change-Number: 45682
Gerrit-PatchSet: 3
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 28 Sep 2020 03:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment