Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38424 )
Change subject: cbfs: Enable CBFS mcache on most chipsets
......................................................................
Patch Set 22: Code-Review+2
It looks reasonable and I think now, shortly after a release is the best time to get it in, given how many different SoCs it impacts directly.
That said, could you send a mail to the list outlining that this change is in with a call for testing (I suppose a simple boot test should be good enough)? That way, if there are issues we can sort them out soon rather than in several months when everybody has already moved on to the next complicated thing?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38424
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0abd1c813aece6e78fb883f292ce6c9319545c44
Gerrit-Change-Number: 38424
Gerrit-PatchSet: 22
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Dec 2020 14:23:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment