Attention is currently required from: Henry Sun, Super Ni, Simon Yang, Ivan Chen, Teddy Shih.
Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68129 )
Change subject: mb/google/dedede/var/beadrix: Update SoC gpio pin of USB camera
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
Hi Simon, […]
ODM confirmed the GPP_D13 is set to GPO/high and don't care voltage level.
File src/mainboard/google/dedede/variants/beadrix/gpio.c:
https://review.coreboot.org/c/coreboot/+/68129/comment/6aa4faa7_e0417361
PS2, Line 33: /* D13 : EN_PP2800_CAMERA */
Could you double check the comment for D13 is match its purpose?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68129
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id00cb85cdad900c03842ad69707966aa62410efd
Gerrit-Change-Number: 68129
Gerrit-PatchSet: 2
Gerrit-Owner: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.corp-partner.google.com
Gerrit-Reviewer: Super Ni
super.ni@intel.corp-partner.google.com
Gerrit-Reviewer: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eddy Lu
eddylu@ami.corp-partner.google.com
Gerrit-CC: Jack Cheng
jack.cheng@ecs.corp-partner.google.com
Gerrit-CC: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Super Ni
super.ni@intel.corp-partner.google.com
Gerrit-Attention: Simon Yang
simon1.yang@intel.corp-partner.google.com
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Attention: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Comment-Date: Thu, 06 Oct 2022 08:47:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Yang
simon1.yang@intel.com
Comment-In-Reply-To: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-MessageType: comment