Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36544 )
Change subject: security/vboot: Add rw_region_only support to vboot ......................................................................
Patch Set 10:
(1 comment)
Patch Set 10: Code-Review+1
(1 comment)
If RW and RO need different objects inside them I think it would make sense to generate them separately or even as a separate files, but that's part of a larger redesign. I guess this is good enough as a stop gap measure for now to support your use case.
Agreed I am definitely interested when a better solution is considered, perhaps adding a "region" option to the cbfs file properties instead of the current regions_for_file mechanism could be used. By doing that you could use the current regions_for_file assignment by default and allow it to be overridden by specifying the regions.
https://review.coreboot.org/c/coreboot/+/36544/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36544/9//COMMIT_MSG@10 PS9, Line 10: it is required to make sure some components : are only added to the RW_REGION.
'required to make sure' begs more questions. […]
Done