Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43303 )
Change subject: soc/amd/common: Use SPI settings from EFS
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43303/5/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:
https://review.coreboot.org/c/coreboot/+/43303/5/src/mainboard/google/zork/v...
PS5, Line 135: SPI_SPEED_66M
I'm all for deleting all this if EFS takes care of setting it up.
https://review.coreboot.org/c/coreboot/+/43303/5/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/spi.h:
https://review.coreboot.org/c/coreboot/+/43303/5/src/soc/amd/common/block/in...
PS5, Line 61: EFS_SPI_ST_READ_MODE
where is this used?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43303
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I765dada14700f4800263d2d3844af07fad0e5b71
Gerrit-Change-Number: 43303
Gerrit-PatchSet: 5
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 23 Jul 2020 15:28:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment