Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35137 )
Change subject: util/abuild: Have abuild generate the .xcompile if it doesn't exist
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35137/2/util/abuild/abuild
File util/abuild/abuild:
https://review.coreboot.org/c/coreboot/+/35137/2/util/abuild/abuild@474
PS2, Line 474: Makefile
What `Makefile` is this? are we making more assumptions from where `abuild` is called?
And please add a comment. How is anyone reading this code supposed
to understand that `Makefile` is included to build `.xcompile`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79ded36d47b0219d0b126adff80a57be1c2bdf07
Gerrit-Change-Number: 35137
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 18 Oct 2019 08:46:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment