Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47232 )
Change subject: soc/intel/jasperlake: Update reserved GPIO names in gpio_soc_defs.h ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/47232/2/src/soc/intel/jasperlake/gp... File src/soc/intel/jasperlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/47232/2/src/soc/intel/jasperlake/gp... PS2, Line 48: LOOPNK Is it supposed to be LOOPBK? i.e. B instead of N?
https://review.coreboot.org/c/coreboot/+/47232/2/src/soc/intel/jasperlake/gp... PS2, Line 132: GPIO_L_BKLTEN nit: If you use GPIO_COM4_START and GPIO_COM4_END and similar other macros in this table, then you won't have to touch this table again if start/end changes in the future.