Patch set 2:Code-Review +2
2 comments:
File src/soc/intel/jasperlake/gpio.c:
Patch Set #2, Line 48: LOOPNK
Is it supposed to be LOOPBK? i.e. B instead of N?
Patch Set #2, Line 132: GPIO_L_BKLTEN
nit: If you use GPIO_COM4_START and GPIO_COM4_END and similar other macros in this table, then you won't have to touch this table again if start/end changes in the future.
To view, visit change 47232. To unsubscribe, or for help writing mail filters, visit settings.