Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35619 )
Change subject: cpu/intel/common: Move intel_ht_sibling() to common folder
......................................................................
Patch Set 5: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/35619/5/src/cpu/intel/common/common...
File src/cpu/intel/common/common.h:
https://review.coreboot.org/c/coreboot/+/35619/5/src/cpu/intel/common/common...
PS5, Line 33: bool
Please include the header that defines this type.
https://review.coreboot.org/c/coreboot/+/35619/5/src/cpu/intel/common/hypert...
File src/cpu/intel/common/hyperthreading.c:
https://review.coreboot.org/c/coreboot/+/35619/5/src/cpu/intel/common/hypert...
PS5, Line 29: 28
Do we not have these bits defined somewhere?
https://review.coreboot.org/c/coreboot/+/35619/5/src/cpu/intel/common/hypert...
PS5, Line 35: < 1
The only valid value to hit this condition. Why don't we just use == 0 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35619
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d000b34ba4c6536dc866fbaf106b78e905e3e35
Gerrit-Change-Number: 35619
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Sep 2019 14:51:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment