Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34174 )
Change subject: soc/intel/icelake: use existing type definition
......................................................................
Patch Set 1:
I understand your concern for using type definition.
C files already used both soc_intel_icelake_config and contig_t.
So, the change is using config_t for all icelake soc c file.
And main reason why we try to use config_t is making more reusable code.
By using config_t, some files can be used directly for other silicon rather than adding same c file in other soc folder.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34174
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05d7ec376d0d4f263a1e27f36b3d37f16a695e61
Gerrit-Change-Number: 34174
Gerrit-PatchSet: 1
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 09 Jul 2019 18:45:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment