[coreboot-gerrit] Change in coreboot[master]: ec/google/chromeec: Introduce SKU_ID helpers

[Jett Rink (Code Review)]

Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39018 )

Change subject: ec/google/chromeec: Introduce SKU_ID helpers
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39018/3/src/ec/google/chromeec/ec_b... 
File src/ec/google/chromeec/ec_boardid.c:

https://review.coreboot.org/c/coreboot/+/39018/3/src/ec/google/chromeec/ec_b... 
PS3, Line 53: if ((sku_id == SKU_UNKNOWN) ||
            : 		(sku_id >  CONFIG_EC_GOOGLE_CHROMEEC_SKU_ID_MAX)) {
            : 		printk(BIOS_ERR, "%s: Unexpected SKU ID %u\n",
            : 			__func__, sku_id);
            : 		return "";
            : 	}
> I am wondering.. is it bad if we just skip this check completely? i.e. […]

+1 to just passing up the value to SMBIOS since the firmware should no longer care about this value. All decision should be based on the firmware configuration field instead now.