Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42521 )
Change subject: mb/pcengines/apu2: Switch to proper GPIO API ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42521/13/src/mainboard/pcengines/ap... File src/mainboard/pcengines/apu2/gpio_ftns.c:
https://review.coreboot.org/c/coreboot/+/42521/13/src/mainboard/pcengines/ap... PS13, Line 14: GPIO_49
This SoC carried two enumerations for GPIOs in the docs, making it confusing indeed. […]
ah, with that info it does make sense to me
https://review.coreboot.org/c/coreboot/+/42521/8/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/romstage.c:
https://review.coreboot.org/c/coreboot/+/42521/8/src/mainboard/pcengines/apu... PS8, Line 43: gpio_output(gpio, 0);
Address this sequence in gpio_banks/gpio.c:gpio_output() instead.
if i saw that correctly this is the only unresolved comment in this patch, but i'd say that this isn't something that should be addressed in this patch. not sure, but i might have a patch on my work machine that fixes the behavior this works around