Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46962 )
Change subject: mb/google/hatch/jinlon: Describe the privacy_gpio ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46962/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/jinlon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46962/4/src/mainboard/google/hatch/... PS4, Line 83:
Can you please use tabs instead of spaces here and for the lines below like the rest of the entries […]
Done
https://review.coreboot.org/c/coreboot/+/46962/4/src/mainboard/google/hatch/... PS4, Line 87: ACPI_GPIO_INPUT_ACTIVE_LOW
Can you please add a comment here explaining why this is being configured as GPIO instead of GPIO_IR […]
Done