Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36093 )
Change subject: mb/lenovo/x200: Add ThinkPad X301 as a variant
......................................................................
Patch Set 6:
(2 comments)
Patch Set 5:
(1 comment)
Commit message mentions superio in dock when x200 doesn't have any there (LPC is not exposed over dock connector either)
Do you mean that x200 has its superio chip on the mainboard?
https://review.coreboot.org/c/coreboot/+/36093/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36093/3//COMMIT_MSG@10
PS3, Line 10: setup, and no docking support, thus no superio chip in dock.
X200* doesn't have SuperIO in dock(ultrabase)
Changed.
https://review.coreboot.org/c/coreboot/+/36093/5/Documentation/mainboard/len...
File Documentation/mainboard/lenovo/x301.md:
https://review.coreboot.org/c/coreboot/+/36093/5/Documentation/mainboard/len...
PS5, Line 45:
Remove trailing newlines.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6a6059ccf15dd2e43ed4fc490c1d3c36aa1e817
Gerrit-Change-Number: 36093
Gerrit-PatchSet: 6
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Comment-Date: Sat, 19 Oct 2019 03:27:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment