Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56074 )
Change subject: mb/google/brya: Add UsbTcPortEn in devicetree ......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/tcss.h:
https://review.coreboot.org/c/coreboot/+/56074/comment/fe263785_9fdf957e PS4, Line 101: having this enum inside soc/alderlake/chip.h would help to understand the purpose of these macros as this are for FSP-UPD filling purpose. Assume we have more number of USB-C ports in next generation then, having such code in common place like this would tough to grow without any meaningful usage for previously generation platform. enum usbc_port_flags { TCSS_PORT0 = BIT(0), TCSS_PORT1 = BIT(1), TCSS_PORT2 = BIT(2), };