[coreboot-gerrit] Change in coreboot[master]: nb/intel/ironlake/raminit.c: initialize 'reply.command'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42461 )

Change subject: nb/intel/ironlake/raminit.c: initialize 'reply.command'
......................................................................

nb/intel/ironlake/raminit.c: initialize 'reply.command'

This to silent a bug found using gcc-10.
src/northbridge/intel/ironlake/raminit.c: In function 'setup_heci_uma':
src/northbridge/intel/ironlake/raminit.c:1805:11: error: 'reply.command' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 1805 |  if (reply.command != (MKHI_SET_UMA | (1 << 7)))
      |      ~~~~~^~~~~~~~
cc1: all warnings being treated as errors

Change-Id: I0d13de549b6d428ac3675ee3f91eb5e42aeb25e8
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/ironlake/raminit.c
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/42461/1

diff --git a/src/northbridge/intel/ironlake/raminit.c b/src/northbridge/intel/ironlake/raminit.c
index e85163f..714cc4b 100644
--- a/src/northbridge/intel/ironlake/raminit.c
+++ b/src/northbridge/intel/ironlake/raminit.c
@@ -1781,6 +1781,10 @@
    	u8 field2;
    	u8 unk3[0x48 - 4 - 1];
    } __packed reply;
+
+	/*FIXME: We should not initialize 'reply.command' */
+	reply.command = 0;
+
    struct uma_message {
    	u8 group_id;
    	u8 cmd;
@@ -1801,7 +1805,6 @@
    reply_size = sizeof(reply);
    if (recv_heci_message(info, (u32 *) & reply, &reply_size) == -1)
    	return;
-
    if (reply.command != (MKHI_SET_UMA | (1 << 7)))
    	die("HECI init failed\n");
 }