Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42078 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC (TCPM)
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42078/9/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/42078/9/src/ec/google/chromeec/ec.c...
PS9, Line 1490: *port_map = resp.reserved;
i wanted to use this method in depthcharge but it was rejected there. […]
Ah, I see. That's true, it can be obtained that way, but we do not have any of that info in the devicetree yet. It is being added right now, see CB:45878.
So then, the way to get at the data would be (on top of the patch mentioned above):
In ec_acpi, use the EC's `struct device *dev` config (chip_info) to get mux_conn[0] for port 0 and mux_conn[1] for port 1. Those dev's config has `usb2_port_number` and `usb3_port_number` fields, which are what we need here. That should go in the mainboard code too, as it's for chromeec boards right now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If994a459288ef31b0e6da8c6cdfd0ce3a0303981
Gerrit-Change-Number: 42078
Gerrit-PatchSet: 14
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-Comment-Date: Wed, 30 Sep 2020 20:32:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment