[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Enable PCH thermal depending on devicetree

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47116 )

Change subject: soc/intel/skylake: Enable PCH thermal depending on devicetree
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47116/2/src/soc/intel/skylake/chip.... 
File src/soc/intel/skylake/chip.c:

https://review.coreboot.org/c/coreboot/+/47116/2/src/soc/intel/skylake/chip.... 
PS2, Line 285: 	params->PchThermalDeviceEnable = dev && dev->enabled;
> The current behaviour may have forced boards to enable the device to follow FSP, but this is preserv […]

no, it is not. This disables the device for all boards, that don't have a devicetree entry setting it to "on".