Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37721 )
Change subject: soc/amd/common: Correct SPI FIFO size check ......................................................................
Patch Set 2:
(1 comment)
Pushed a strawman here: https://review.coreboot.org/c/coreboot/+/37957
https://review.coreboot.org/c/coreboot/+/37721/2/src/soc/amd/common/block/sp... File src/soc/amd/common/block/spi/fch_spi_flash.c:
https://review.coreboot.org/c/coreboot/+/37721/2/src/soc/amd/common/block/sp... PS2, Line 44: if ((cmd_len - 1 + data_len) > SPI_FIFO_DEPTH) FWIW, this check shouldn't be in here since crop_chunk already took this into account.