8 Sep
2019
8 Sep
'19
2:19 p.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34948 )
Change subject: superio/nuvoton: add a driver for nct668xd ......................................................................
Patch Set 8:
Patch Set 8: Code-Review+1
looks good to me; will wait with the +2 though until there's a patch adding a board that uses this SIO support, so that this code gets build-tested. SIO code (well, driver code in general) only gets build-tested when there's some board selecting the driver
I had a board that used it (see 34947) but unfortunately the board is dead so I can't continue here. Maybe someone with a Lenovo TS P320 or TC M800/M900 (same board) wants to finish this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34948
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78eca4ba2948c36a386306887f62773580f6e444
Gerrit-Change-Number: 34948
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 08 Sep 2019 12:19:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment