Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38772 )
Change subject: mb/google/dedede: Enable AP <-> H1 Communication
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38772/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38772/2/src/mainboard/google/dedede...
PS2, Line 73: on
In addition to this, you also need to set SerialIoDevMode FSP UPD to ensure that FSP keeps the controller enabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38772
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37972635454cd0d35608623e7be4110012ace658
Gerrit-Change-Number: 38772
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Fri, 07 Feb 2020 21:57:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment