Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36545 )
Change subject: lib/cbfs: Add fallback to RO region to cbfs_boot_locate
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36545/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36545/1//COMMIT_MSG@11
PS1, Line 11: static files that are not intended to be updated to the RW regions.
Using cbfs_locate_file_in_region is not an option in our case. This would be fine if we only needed this for items only relevant to our mainboard but in our case, other files are concerned as well and changes would be needed in several parts of the tree.
OK. I think you may be creating a hard to maintain situation, but it's your product offering.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81ceaf927280cef9a3f09621c796c451e9115211
Gerrit-Change-Number: 36545
Gerrit-PatchSet: 1
Gerrit-Owner: Wim Vervoorn
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Wim Vervoorn
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Nov 2019 16:22:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Wim Vervoorn
Gerrit-MessageType: comment