build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42608 )
Change subject: mb/up/squared: rewrite GPIO config using intelp2m ......................................................................
Patch Set 1:
(46 comments)
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... File src/mainboard/up/squared/gpio.h:
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 22: PAD_FUNC(GPIO) | PAD_RESET(PWROK) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 27: PAD_FUNC(GPIO) | PAD_RESET(PWROK) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 48: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 52: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 56: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 60: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 64: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 68: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 72: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 80: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 84: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 94: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 98: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 102: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 111: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 115: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 123: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 127: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 135: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 139: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 144: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 149: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 154: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 159: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 163: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 175: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 334: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 339: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 344: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 434: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 438: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 442: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 450: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 472: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 477: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 482: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 497: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 825: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 870: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 874: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 887: PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_RX(1), PAD_IOSSTATE(IGNORE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 907: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 917: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 995: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | PAD_RX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 1010: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/1/src/mainboard/up/squared/gp... PS1, Line 1015: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | PAD_TX(1), line over 96 characters