Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35822 )
Change subject: arch/x86: Add a choice for selecting normal/fallback cbfs prefix
......................................................................
Patch Set 3:
Patch Set 3:
CB:438 (!)
I don't think the argument about needing 'Kconfig' surgery in external tree's is a good argument as you need way more than just Kconfig surgery to make it work with more than 2 prefixes. With 2 prefixes all you can do is a cosmetic renaming. And even if those external trees have that, the option for a user selectable Kconfig is still there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35822
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04222120bd1241c3b0996afa27dcc35ac42fbbc8
Gerrit-Change-Number: 35822
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 07 Oct 2019 17:40:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment