[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/herobrine: Enable early eMMC init in coreboot

[Shelley Chen (Code Review)]

Attention is currently required from: Paul Menzel, Julius Werner.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71830 )

Change subject: mb/google/herobrine: Enable early eMMC init in coreboot
......................................................................

Patch Set 12:

(1 comment)

File src/mainboard/google/herobrine/mainboard.c:

https://review.coreboot.org/c/coreboot/+/71830/comment/c6a55e64_37abe8a0 
PS8, Line 113: 	qc_emmc_early_init();
> Excuse my ignorance, but can’t this be controlled by a Kconfig option, and the call be done in the S […]

I think that yes, it could be technically done in the soc code, but I feel like it's much clearer having the initialization call here along with the SD card initialization.  This seems to be how MTK is structuring their early emmc init code as well.