Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48279 )
Change subject: soc/intel/common: Move CSE Lite driver functionality into romstage
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Just a note - this CL will have to be cherry-picked along with the follow-up changes in chromium tree to ensure we don't break the behavior on any TGL/JSL boards.
https://review.coreboot.org/c/coreboot/+/48279/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48279/2//COMMIT_MSG@13
PS2, Line 13: Verified on JSL and TGL platforms
Ack
Can you please add that detail to the commit message?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48279
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fd562a5c6c8501226abbcb68021d9356bcf0b73
Gerrit-Change-Number: 48279
Gerrit-PatchSet: 6
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Dec 2020 04:49:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment