HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39816 )
Change subject: src: Include <smbios.h> when appropriate
......................................................................
Patch Set 4:
(1 comment)
Thank you.
https://review.coreboot.org/c/coreboot/+/39816/4/src/soc/intel/braswell/chip...
File src/soc/intel/braswell/chip.h:
https://review.coreboot.org/c/coreboot/+/39816/4/src/soc/intel/braswell/chip...
PS4, Line 27: smbios
Indirect inclusion, which is pretty annoying
I think that smbios is missing here: "src/include/device/device.h"
it will add it to "static.c" and will be used by "devicetree.cb"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39816
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12345a5b6c9ce94ca9f8b555154b2278a8ff97bf
Gerrit-Change-Number: 39816
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 29 Mar 2020 10:32:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment