Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41159 )
Change subject: mainboard: Add HP EliteBook 2560p ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41159/2/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/2560p/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41159/2/src/mainboard/hp/snb_ivb_la... PS2, Line 8: 0x0
0
Done
https://review.coreboot.org/c/coreboot/+/41159/2/src/mainboard/hp/snb_ivb_la... PS2, Line 12:
Add an extra space to align the "end" words?
Done
https://review.coreboot.org/c/coreboot/+/41159/2/src/mainboard/hp/snb_ivb_la... PS2, Line 21: 1
I don't think the SD/MMC Host Controller is hotpluggable
I don't know why autoport gives me pcie_hotplug_map[2]=1 while pcie_hotplug_map[1]=0 on the EliteBooks. pcie_hotplug_map[1]=1 is needed for ExpressCard hotplug, so the current device tree for EliteBooks are all pcie_hotplug_map={0,1,1,...}.