Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten.
Mark Hasemeyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74592 )
Change subject: mb/google/skyrim: Add named GPIO's
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/skyrim/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/74592/comment/c6e545b4_879b5f1a
PS2, Line 38: .gpio_group_id = SSD_AUX_RST_L,
SD_AUX_RST_SOC_L
File src/mainboard/google/skyrim/variants/markarth/gpio.c:
https://review.coreboot.org/c/coreboot/+/74592/comment/9bf73a92_94f111bc
PS2, Line 10: PAD_NC(GPIO_3),
I know these are not named b/c they are not used, but it feels like another place in code we could forget to update values if pins move around (b/c of rework or new proto, etc). I could see us updating the value of `SOC_PEN_DETECT_ODL` and forget to change it here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74592
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If907478442ea7acb80b2e413926d173d188ce340
Gerrit-Change-Number: 74592
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Comment-Date: Fri, 21 Apr 2023 15:42:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment